Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS type for changeset.errors #393

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix TS type for changeset.errors #393

merged 1 commit into from
Jan 10, 2020

Conversation

josemarluedke
Copy link
Contributor

Errors have the "validation" key, which has the error messages from validations.

josemarluedke
josemarluedke commented Jan 9, 2020
View reviewed changes
addon/-private/validated-changeset.ts

if (isObject(value)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was always true as it as always returned an object from the transform method.

@josemarluedke josemarluedke changed the title Fix TS type for errors Fix TS type for changeset.errors Jan 9, 2020
@snewcomer snewcomer added the bug label Jan 10, 2020
snewcomer
snewcomer approved these changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Great PR.

@snewcomer snewcomer merged commit feb8044 into adopted-ember-addons:master Jan 10, 2020
@snewcomer snewcomer mentioned this pull request Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarluedke @snewcomer