Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicErrors type #411

Merged
merged 1 commit into from
Jan 17, 2020
Merged

PublicErrors type #411

merged 1 commit into from
Jan 17, 2020

Conversation

snewcomer
Copy link
Collaborator

ref #410

@snewcomer snewcomer self-assigned this Jan 17, 2020
snewcomer
snewcomer commented Jan 17, 2020
View reviewed changes
addon/types/index.ts
changes: object[],
errors: object[],
changes: Record<string, any>[],
errors: PublicErrors,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josemarluedke whaddy think?

josemarluedke
josemarluedke approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@josemarluedke josemarluedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for working on this.

@snewcomer snewcomer merged commit 5b5d8b8 into master Jan 17, 2020
@snewcomer snewcomer deleted the sn/public-errors branch January 17, 2020 22:21
@josemarluedke josemarluedke mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarluedke josemarluedke josemarluedke approved these changes

Assignees

@snewcomer snewcomer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snewcomer @josemarluedke @SergeAstapov