Failing test case for validating computed property #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyfel
force-pushed
the
validate-computed-property
branch
from
6dd3acb to
04b201c
Compare
The use case is the following: I want to be able to validate derived state, not the root state. So, model contains a bunch of changes, but the condition of validity is defined based on several changes. With the regular approach when changes are applied to a model, I can define a computed property (or a getter) and validate against it. With the changeset approach, model's computed property won't be updated because the model itself is not changed. So, the idea is to define a computed property on the Changeset level. But it isn't even evaluated. This case has been supported in validated-changeset. This PR adds a test on the ember-changeset level.
andreyfel
force-pushed
the
validate-computed-property
branch
from
04b201c to
0f9e301
Compare
The issue which this PR illustrates was fixed in validated-changeset@0.5.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it is supposed to work, but this PR illustrates the issue.
The use case is the following:
I want to be able to validate derived state, not the root state.
So, model contains a bunch of changes, but the condition of validity
is defined based on several changes.
With the regular approach when changes are applied to a model, I can
define a computed property (or a getter) and validate against it.
With the changeset approach, model's computed property won't be updated
because the model itself is not changed. So, the idea is to define a
computed property on the Changeset level. But it isn't even evaluated.
Illustrates #474