Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ember-cli-update to v3.28.3 and enable Ember v4 scenarios #617

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Run ember-cli-update to v3.28.3 and enable Ember v4 scenarios #617

merged 1 commit into from
Oct 27, 2021

Conversation

SergeAstapov
Copy link
Contributor

No description provided.

@SergeAstapov
Copy link
Contributor Author

@snewcomer there is one test case observing #rollback values that fails once I pull all the latest updates.

Not sure I understand how addObserver works on the Changeset instance, so will try to find the root cause.

@SergeAstapov
Copy link
Contributor Author

Figured out the root cause of previous failure:
as this PR set "default-async-observers": true, fixed the test to use await settled() to ensure proper timing of assertions

Now have another issue with Embroider + Ember Data compatibility:

Error: Could not find module `@ember-data/model/-private` imported from `(require)`

Did update all the dependencies and refreshed package-lock.json in this PR as well, so will keep digging.

@SergeAstapov
Copy link
Contributor Author

Hooray! This is now pass!
Had to use "@embroider/test-setup": "^0.42.3" as there are compatibility issues with latest versions of Ember Data + Embroider.

Checked all the versions of @embroider/test-setup past 0.43.0 and apparently all emit an error

Error: Could not find module `@ember-data/model/-private` imported from `(require)`

As this addon does not depend on Ember Data, I think this is not an issue for this PR.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@snewcomer
Copy link
Collaborator

Great point on the e-d issues. There is some custom hacks but I know we have some medium level effort to get ember-data in compat with embroider.

@snewcomer snewcomer merged commit d639bc1 into adopted-ember-addons:master Oct 27, 2021
@SergeAstapov SergeAstapov deleted the ember-cli-update branch October 27, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants