Modernize readme examples #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorncom
approved these changes
Oct 23, 2024
|
|
||
| ```js | ||
| let changeset = Changeset(model, validatorFn, validationMap, { skipValidate: true }); | ||
| ``` | ||
|
|
||
| ```hbs | ||
| {{#let (changeset model this.validate skipValidate=true) as |changesetObj|}} | ||
| {{#let (changeset this.model this.validate skipValidate=true) as |changesetObj|}} |
There was a problem hiding this comment.
this.model, and all usages of the word "model" should be changed to be "this.data", imo.
SergeAstapov
force-pushed
the
update-readme
branch
from
117b1dd to
5fc3c7b
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme has a few pre-Octane examples and patterns which we should modernize