Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ember CLI blueprints to 3.26.0 #198
Update Ember CLI blueprints to 3.26.0 #198
Changes from 4 commits
d50a7ad
368d0bb
4b8c04c
d898902
b88c50c
700b936
06f2763
509315f
973fc08
9332dcc
759e425
5d9ee65
73e5736
5546043
b598409
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new scenarios for Ember 3.16, 3.20 and Embroider should be added without replacing the existing scenarios. We need them to ensure that we do not break compatibility commitment without noticing. Maybe we should add a Ember 3.12 scenario as well to cover all LTS versions since 2.18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear I got confused. The addon does not seem to run Ember Try at all. It uses a custom setup to test against multiple Ember CLI versions: https://github.com/rwjblue/ember-cli-content-security-policy/blob/master/.github/workflows/ci.yml#L145
This implicitly covers ember-source versions as well. But does not include ember-source@2.18.
It also means that Embroider tests are not run yet. Even after merging this one.
I guess we need to revisit the compatibility guarantee and test suite. But it could be done independently from this merge request.
I'm sorry that I asked you to put time into updating the ember try configuration.