-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add base css class to {{flash-message}} #133
Comments
I mean it's not too hard to do |
Sure! |
@poteto I ran across this and thought I'd knock this out. It's a one-liner if you don't care about tests. Do you want me to specifically test this or no? |
@jfelchner I would test for it, since if it were to be removed accidentally and people started using it, it would be a bug. On the other hand, I am a bit of an extreme tester. |
Great idea - looking forward to this feature |
I'm not using bootstrap or foundation. It would be nice to have a more specific way of selecting than:
<div id="ember1749" class="ember-view alert alert-info active">
so it doesn't collide with other potential selectors. I propose "flash-message" so it would be<div id="ember1749" class="ember-view flash-message alert alert-info active">
. I would be open to doing the PR if it's approved.The text was updated successfully, but these errors were encountered: