Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base css class to {{flash-message}} #133

Closed
kellyselden opened this issue Feb 17, 2016 · 5 comments
Closed

add base css class to {{flash-message}} #133

kellyselden opened this issue Feb 17, 2016 · 5 comments
Milestone

Comments

@kellyselden
Copy link

I'm not using bootstrap or foundation. It would be nice to have a more specific way of selecting than: <div id="ember1749" class="ember-view alert alert-info active"> so it doesn't collide with other potential selectors. I propose "flash-message" so it would be <div id="ember1749" class="ember-view flash-message alert alert-info active">. I would be open to doing the PR if it's approved.

@kellyselden
Copy link
Author

I mean it's not too hard to do {{flash-message class="flash-message" flash=flash}}, just curious if you wanted it default.

@poteto
Copy link
Collaborator

poteto commented Feb 17, 2016

Sure!

@poteto poteto added this to the 2.0.0 milestone Feb 18, 2016
@jfelchner
Copy link
Contributor

@poteto I ran across this and thought I'd knock this out. It's a one-liner if you don't care about tests. Do you want me to specifically test this or no?

@kellyselden
Copy link
Author

@jfelchner I would test for it, since if it were to be removed accidentally and people started using it, it would be a bug. On the other hand, I am a bit of an extreme tester.

@wcurtis
Copy link

wcurtis commented Mar 21, 2017

Great idea - looking forward to this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants