Add active class in run.next instead of afterRender queue #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the active class is added at the exact same time the message is rendered (despite the afterRender queue). This will ensure that the active class is added 1ms after it is inserted into the DOM, thus triggering any CSS transitions from naked to active states.
kmiyashiro
force-pushed
the
tick-active-class
branch
from
7fe481e to
4deddc7
Compare
|
Thanks! |
poteto
added a commit
that referenced
this pull request
Nov 25, 2015
Add active class in run.next instead of afterRender queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the active class is added at the exact same time the message is
rendered (despite the afterRender queue). This will ensure that the active
class is added 1ms after it is inserted into the DOM, thus triggering any CSS
transitions from naked to active states.