Modernise FlashMessagesService
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NullVoxPopuli I have pushed the upstream branch but GitHub hasn't updated the PR page for some reason. I'll circle back in a while and re-stage if it doesn't update Edit: it caught up |
gilest
force-pushed
the
refactor/modernise-service
branch
from
9186cab to
a75ea76
Compare
NullVoxPopuli
approved these changes
Mar 13, 2024
This was referenced Mar 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces computeds, EmberArray, set/get, prototype extensions with native JS features.
Should make the conversion to TypeScript much easier.
Breaking since the types of these properties will be changing. Targeting
6.0.0with all of the other breaking modernisation changes. Hopefully we can ship new types in the same release.