Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Dart Sass #184

Closed
nex3 opened this issue Mar 23, 2018 · 0 comments
Closed

Add support for Dart Sass #184

nex3 opened this issue Mar 23, 2018 · 0 comments

Comments

@nex3
Copy link
Contributor

nex3 commented Mar 23, 2018 •
edited
Loading

Dart Sass is in Release Candidate phase now, with a full release probably coming next week. It would be great to add support to this package for choosing between Node Sass and Dart Sass. I'm willing to create a pull request, but I'm not sure what the best design would be.

I expect this is blocked on adopted-ember-addons/broccoli-sass-source-maps#26, but I wanted to have an issue here to track progress.
@nex3 nex3 mentioned this issue Mar 23, 2018
Closed
7 tasks
nex3 added a commit to nex3/ember-cli-sass that referenced this issue Jul 11, 2018
@nex3
Make this package implementation-agnostic
d6d6f4e 
Rather than always loading Node Sass, this now requires users to pass
in either Dart Sass or Node Sass as an option to the plugin.

Closes adopted-ember-addons#184
@nex3 nex3 mentioned this issue Jul 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nex3