Bump @ember/test-helpers from 2.9.3 to 3.1.0 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anas7asia
approved these changes
Jun 26, 2023
SkoebaSteve
reviewed
Jun 26, 2023
There was a problem hiding this comment.
@CYriuk bumping ember-qunit to v7 does seem to remove support for ember 3.28 according to the CI run: https://github.com/adopted-ember-addons/ember-launch-darkly/actions/runs/5376916809/jobs/9754938906?pr=492#step:5:240
If we merge this, it would mean a breaking change on ember-launchdarkly 🤔
Indeed! Is it acceptable to move to a new major dropping this support? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @ember/test-helpers from 2.9.3 to 3.1.0.
This PR is a duplicate from #481 which includes a needed bump for
ember-qunitfromv6.2.0tov7.0.0