Epic/multiple properties ga master #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jherdman @poteto @chrismllr thanks |
jherdman
reviewed
Oct 29, 2020
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ember-metrics", | |||
| "version": "0.16.0", | |||
There was a problem hiding this comment.
Revert, and please remove package-lock.json
There was a problem hiding this comment.
why, don't want to create a new release for that?
There was a problem hiding this comment.
This is up to the maintainers. Please remove.
There was a problem hiding this comment.
removing package-lock yes (and adding to gitignore next then) - although it is recommended to checkout package-lock in general
There was a problem hiding this comment.
removed package-lock and added to gitignore
There was a problem hiding this comment.
reverted package bump then
jherdman
requested changes
Oct 29, 2020
Leooo
force-pushed
the
epic/multiple-properties-ga-master
branch
from
413da71
to
46746a0
Compare
|
lovely, I screwed up everything. Bloody force-push. Let me recreate a PR @jherdman |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #217 (comment)