-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme for Ember Octane #140
Conversation
@@ -152,24 +127,15 @@ Using angle bracket invocation: | |||
|
|||
Two arguments are passed to the block: `message` object, and `close` action. Make sure | |||
you are using *Closure Actions* syntax passing the action (e. g. `<a {{action close}}` or | |||
`{{your-component close=(action close)}}`. | |||
`<YourComponent @close={{action close}} />`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
binding should be done internally using @action
decorator to drop that requirement and simplify to <YourComponent @close={{close}} />
. But will leave that one for another PR.
Thanks! Overall looks good. I'll wait until Octane is released before merging. |
@btecu Thanks for your review! Addressed the comments. Do you want me to squash or will you squash it when you merge the PR anyway? |
@jelhan I can squash when merging. |
Thanks @jelhan! |
Updates the readme for Ember Octane. In detail it does:
{{on}}
element modifier for event binding instead of{{action}}
.@action
decorator instead ofactions
hash in the examples.