[paper-input] preventing exception when typing with mobile keyboard (#…

…551) test `isDestroyed` before running `setValue`
adopted-ember-addons · Nov 8, 2016 · 0fb9433 · 0fb9433
1 parent 22c5695
commit 0fb9433
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ Contributions and pull requests are always welcome. Contributors may often be fo
 ### master
 - [#542](https://github.com/miguelcobain/ember-paper/pull/542) paper-form now yields a submit button
 - [#549](https://github.com/miguelcobain/ember-paper/pull/549) Allow `title` attribute in paper-button
+- [#551](https://github.com/miguelcobain/ember-paper/pull/551) avoids calling setValue when the component is destroyed
 
 ### 1.0.0-alpha.7 (November 2, 2016)
 - [#531](https://github.com/miguelcobain/ember-paper/pull/531) paper-select focus fix - doesn't call focusTarget.focus if there is no focusTarget (which is perfectly possible)

diff --git a/addon/components/paper-input.js b/addon/components/paper-input.js
@@ -142,6 +142,9 @@ export default Component.extend(FocusableMixin, ColorMixin, ChildMixin, Validati
       this.sendAction('onChange', e.target.value);
       // setValue below ensures that the input value is the same as this.value
       run.next(() => {
+        if (this.isDestroyed) {
+          return;
+        }
         this.setValue(this.get('value'));
       });
       this.growTextarea();