fix(...) input validations

1. For paper-input, validate only when value changes 2. For paper-autocomplete, validate when selection is made.
adopted-ember-addons · Jul 16, 2018 · ce63371 · ce63371
1 parent 7f77a7d
commit ce63371
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/addon/components/paper-autocomplete.js b/addon/components/paper-autocomplete.js
@@ -105,6 +105,11 @@ export default PowerSelect.extend(ValidationMixin, ChildMixin, {
     this._super(...arguments);
   },
 
+  updateSelection() {
+    this._super(...arguments);
+    this.notifyValidityChange();
+  },
+
   actions: {
 
     onTriggerMouseDown() {

diff --git a/addon/components/paper-input.js b/addon/components/paper-input.js
@@ -71,7 +71,13 @@ export default Component.extend(FocusableMixin, ColorMixin, ChildMixin, Validati
   didReceiveAttrs() {
     this._super(...arguments);
     assert('{{paper-input}} requires an `onChange` action or null for no action.', this.get('onChange') !== undefined);
-    this.notifyValidityChange();
+
+    let value = this.get('value');
+    let prevValue = this.get('_prevValue');
+    if (value !== prevValue) {
+      this.notifyValidityChange();
+    }
+    this._prevValue = value;
   },
 
   didInsertElement() {