-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ember-basic-dropdown #1098
Comments
And |
@miguelcobain we love this addon but the above question would be good to get a sense of. Is work on this addon stalled out? Does the community need to pull together to keep it going? What needs to happen to get to 1.0? |
@miguelcobain Let us know if you want/need an extra ✋. 🙏 |
The problem here is that newer versions of ebd/eps require ember 3.11. So, in theory this should require a bump to 2.0.0, is that right? Any suggestions? |
So, I rebuilt paper-menu, paper-select and paper-autocomplete using the new ebd and eps versions. It's on master. All tests are passing, but it would be great if you guys could test these on your apps as well. This also includes other changes like using @betocantu93 this also includes some changes to these components directories. This requires some updates on the blacklist/whitelisting feature that you built. |
@miguelcobain great, on it. I think I don't need to worry about styles, right? those come from angular-material-styles and the treeForStyles logic should remain intact? |
@betocantu93 your work was also selectively importing the needed styles. But yes, everything regarding styles should still apply. |
@miguelcobain Here's the PR #1118 |
@miguelcobain I think a 2.0 release makes sense. A bit funny but, won't hose folks depending on the beta releases. |
After trying the branch for some time on our app, everything seems to work normally. |
@miguelcobain thanks for the release. Did the latest |
@chbonser Yes, indeed ember-paper |
ember-basic-dropdown
made major changes in the 2.x release which is not currently compatible with ember-paper.The text was updated successfully, but these errors were encountered: