-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUEST] Octane #1117
Comments
are you an octane main? |
@v3ss0n I don't know what that means |
Why is this closed? |
@lolmaus the initiative didn't got any feedback by the community, but let's update the scope and reopen, see how it goes |
@betocantu93 The issue is absolutely legit. I believe, it is inevitable that Ember Paper will be eventually upgraded to Octane, refactored to angle brackets, etc. So it makes perfect sense to have a ticket to track progress. That said, acknowledgement from addon maintainers would be really nice. |
As the project's maintainer, I fully acknowledge this refactor. I think we shouldn't go for glimmer components just yet.
If anyone wants to PR a refactor of a component, please do so. |
@miguelcobain Great! sounds like a plan. I'll try to get some componets with native classes, decorators and modern templates, and update according tests and doc. How would you like to handle avoiding mixins? class decorator? or just utils? |
It depends. For example, we use the transition mixin (coming from ember-css-transitions). It's an example of where a new well thought out ember primitive completely changed how that addon looks. :) Other examples like the ColorMixin and FocusableMixin I think can be easily replaceable by directly setting the correct classes in the components themselves. The ValidationMixin probably requires some more thought as it is more complex. The RippleMixin I think can be migrated to a component. It would make ripples much more composable. Imagine having a We don't need to migrate away from mixins all at once. We can use this approach if migrating away from some mixin isn't practical at the moment: class PaperComponent extends Component.extends(Mixin) {
// class body
} |
That is good news to hear. I use ember paper and think it is pretty gosh darn amazing - thanks to all of you who work on it! |
Released |
You can hit a lot of points using Ember CLI Update Codemods especially to do with the change to Angle Brackets. Then template linting can point you to where things like |
New tracking issue: #1213 |
Hello, happy new year, the Octane year. Here's a list of todos to bring Octane to this add-on.
Related issues
The text was updated successfully, but these errors were encountered: