Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations when upgrading to Ember >= v3.20.x, {{-in-element}} #1165

Closed
hergaiety opened this issue Sep 16, 2020 · 1 comment · Fixed by #1201
Closed

Deprecations when upgrading to Ember >= v3.20.x, {{-in-element}} #1165

hergaiety opened this issue Sep 16, 2020 · 1 comment · Fixed by #1201

Comments

@hergaiety
Copy link

A few components in ember-paper rely on the private Ember API of {{-in-element}}, everything after Ember v3.20.x has deprecated that private API in favor of the now public {{in-element}}. https://github.com/emberjs/ember.js/releases/tag/v3.20.0

RFC for this change in Ember

Example: https://github.com/miguelcobain/ember-paper/blob/master/addon/templates/components/paper-tooltip.hbs
@mohitsud
Copy link

same issue- would love to see this resolved.

shearichard added a commit to shearichard/ember-paper that referenced this issue Oct 7, 2021
@shearichard
Changed references to '-in-element' and changed to 'in-element'
4f690f3 
This changed is based on adopted-ember-addons#1165
@Subtletree Subtletree mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update blocking dependencies and codebase Subtletree/ember-paper
2 participants
@hergaiety @mohitsud