Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark date inputs as valid when (partially) cleared #1154

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Mark date inputs as valid when (partially) cleared #1154

merged 1 commit into from
Jun 12, 2020

Commits on Jun 5, 2020

  1. Mark date inputs as valid when (partially) cleared 

    Chrome 83 has removed the clear button from date inputs, which means that there's now no way to clear a date field and have its validity state correctly updated.  Since the `oninput` event fired when the first date component is cleared provides an empty string as the new value, we can detect this and override `validity.badInput` to immediately update our validity state in order to avoid leaving the field permanently flagged as invalid.

Fixes adopted-ember-addons#1153
    @pauln
    pauln committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    dc2f085 View commit details
    Browse the repository at this point in the history