Fixes query linear progress to demo switch from query to determinate. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, the determinate progress bar was getting 'stuck' because the bar style wasn't bound to the mode. So when the mode changed, the bar style wasn't updated.
2 tasks
openhouse
pushed a commit
to wowbot2/ember-paper
that referenced
this pull request
Jun 9, 2016
* commit 'adf876be15ede06e4e8def87a5430259c4951a57': (24 commits) fix paper-item tests dummy app: Adjust sidenav snippet to conform to indentation standard. dummy app: Correct sidenav snippet to avoid conflict with dialog snippet. dummy app: bump ember-cli-github-pages to 0.1.0 as required for "destination" support. fix table scroll on mobile. fix inner sidenav container on mobile fix card page on mobile stop propagation of expand click events Adjusted `ember-css-transitions` dependency to a tagged release. Fixes query linear progress to demo switch from query to determinate. (adopted-ember-addons#391) fix didInitAttrs deprecations use yielded action added tests fix for issue adopted-ember-addons#378 (adopted-ember-addons#390) changed order of css modifications to match AM (adopted-ember-addons#386) Allow null or undefined errors initialization (adopted-ember-addons#389) allow lockedOpen to lock to a boolean improve sidenav docs update changelog use paper-toolbar-tools make sidenavs private. sidenav-toggle no longer gets the lockedOpen value. added some guards on the lockedOpen changes ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the determinate progress bar was getting 'stuck'
because the bar style wasn't bound to the mode. So when the mode
changed, the bar style wasn't updated.