Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[paper-input] preventing exception when typing with mobile keyboard #551

Merged
merged 4 commits into from
Nov 8, 2016
Merged

[paper-input] preventing exception when typing with mobile keyboard #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f78ef30
preventing exception when typing on mobile
Juraci Nov 8, 2016
9095b06
Fixes the root cause
Juraci Nov 8, 2016
395b6f4
making jscs pass
Juraci Nov 8, 2016
a6fdfc9
Adding entry to changelog
Juraci Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Contributions and pull requests are always welcome. Contributors may often be fo
### master
- [#542](https://github.com/miguelcobain/ember-paper/pull/542) paper-form now yields a submit button
- [#549](https://github.com/miguelcobain/ember-paper/pull/549) Allow `title` attribute in paper-button
- [#551](https://github.com/miguelcobain/ember-paper/pull/551) avoids calling setValue when the component is destroyed

### 1.0.0-alpha.7 (November 2, 2016)
- [#531](https://github.com/miguelcobain/ember-paper/pull/531) paper-select focus fix - doesn't call focusTarget.focus if there is no focusTarget (which is perfectly possible)
Expand Down
3 changes: 3 additions & 0 deletions addon/components/paper-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ export default Component.extend(FocusableMixin, ColorMixin, ChildMixin, Validati
this.sendAction('onChange', e.target.value);
// setValue below ensures that the input value is the same as this.value
run.next(() => {
if (this.isDestroyed) {
return;
}
this.setValue(this.get('value'));
});
this.growTextarea();
Expand Down