Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies incl. Ember 2.14 #747

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

bjornharrtell
Copy link
Contributor

@bjornharrtell bjornharrtell commented Jul 8, 2017

Appears to be working fine except the virtual repeat.

Remaining tasks:

  • Fix lint problems
  • Fix "Assertion Failed: Cannot call get with 'options' on an undefined object." in the virtual repeat sample
  • Fix qunitjs upgrade issues

@bjornharrtell bjornharrtell changed the title WIP: Upgrade dependencies incl. Ember 2.14 Upgrade dependencies incl. Ember 2.14 Jul 8, 2017
@bjornharrtell
Copy link
Contributor Author

Ready for review.

@bjornharrtell
Copy link
Contributor Author

Forgot to check qunit issues. Will do so and return with a new reviewable state.

@bjornharrtell
Copy link
Contributor Author

Hit by the qunit issue as fixed/described by #694 only this time it does not appear to help to pin the qunitjs version. :(

@bjornharrtell
Copy link
Contributor Author

I just now noticed that running a failing test in isolation makes it pass.

@bjornharrtell
Copy link
Contributor Author

Think I've found the test case issue and fixed it. The Ember beta build fails at CI but I suspect it has nothing to do with this PR.

@bjornharrtell
Copy link
Contributor Author

Rebased. CI fails completely but I don't understand why, it seems it's not using the .travis.yml that's in this branch (unchanged from master).

@bjornharrtell
Copy link
Contributor Author

Rebased again. Still failing at CI but it runs as expected, failure is with ember-beta which is the same on the master branch.

@bjornharrtell
Copy link
Contributor Author

Rebased and squashed.

@miguelcobain
Copy link
Collaborator

beta and canary are expected to fail. It's an upstream problem.
Thanks for this. Will merge once tests finish running.

@miguelcobain miguelcobain merged commit 6ba3cb1 into adopted-ember-addons:master Jul 21, 2017
@bjornharrtell bjornharrtell deleted the deps-up branch July 21, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants