Use native passive event listeners for ripple and tooltip #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Subtletree Hi, how's this PR going? Maybe we could split it so that we can at least merge the |
Subtletree
changed the title
|
Think that's a good call to split it, I haven't looked at this since I posted it. I've renamed this PR and will open an issue about removing the remaining jquery handlers. @miguelcobain Your thoughts on merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
on/offwithaddEventListener/removeEventListener.passive: truewhere possible. (Anywhere where the handler does not callpreventDefault)Ripple mixin needsunbindEventsUnnecessary as listeners are removed when element is destroyed in browsers newer than ie 7
These two uses of
passive: trueremove 200 scroll-blocking violations in the test suite.Related: #843