[Bug]: Fix async validations #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/fix-async-validation
branch
2 times, most recently
from
1649ba0 to
b7e92db
Compare
snewcomer
force-pushed
the
sn/fix-async-validation
branch
from
b7e92db to
3d705ff
Compare
snewcomer
commented
Feb 25, 2021
| const expectedError = { delayedAsync: { validation: false, value: 'second' } }; | ||
| expect(dummyChangeset.changes).toEqual(expectedChanges); | ||
| expect(dummyChangeset.error).toEqual(expectedError); | ||
| }); |
There was a problem hiding this comment.
@BryanCrotaz fyi
| let running: RunningValidations = this[RUNNING_VALIDATIONS]; | ||
| let promises = Object.entries(running); | ||
|
|
||
| return Promise.all(promises).then(() => { |
There was a problem hiding this comment.
So the idea here is to finish all existing validations before starting the next one in line. This won't block user interaction since the key already has been set on the changeset. This is just an async path that will update the changset *sometime later.
This was referenced Feb 25, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #106 #105