-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix procdump #89
Fix procdump #89
Conversation
Signed-off-by: Simon Rushton <srushton@redhat.com>
Signed-off-by: Simon Rushton <srushton@redhat.com>
Signed-off-by: Simon Rushton <srushton@redhat.com>
sanity.system test runs are in |
Fixes #86 |
Could we please squash the commits into a single commit? |
The PR looks good. The Grinders above didn't really run the code added in this PR. It'd be conclusive to see a test where we have a "hang" and the procdump tool gets invoked successfully. Running a simple grinder with the original failing test didn't give us the original "hang", as it's an intermittent issue. So, I added a target for Output from 1.CL.jvmdump.stdout:
I am not sure what exact Perl version (32 bit or 64 bit) was used in the build. It says: "This is perl 5, version 30, subversion 3 (v5.30.3) built for x86_64-cygwin-threads-multi". |
I would imagine 32 bit perl would say "built for x86_32-cygwin-threads-multi", and it would be included in a 32 bit cygwin installation. |
No reason not to squash. Using github's "Squash and merge" is easiest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.