Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added German translation for the page "Temurin™ Download Buttons" #3058

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jonelo
Copy link

@jonelo jonelo commented Sep 8, 2024

Description of change

I have added German translation for the page "Temurin™ Download Buttons".
German is my mother tongue.

Checklist

  • documentation is changed or added (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 057b6ec
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/671b7263dc5fd70008a3b82b
😎 Deploy Preview https://deploy-preview-3058--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xavierfacq
Copy link
Member

Hi, Thank you for your commit!

I can't see your translation when I go to this preview page: https://deploy-preview-3058--eclipsefdn-adoptium.netlify.app/de/temurin/buttons/

I wonder if it's normal 🤔

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (d31e574) to head (057b6ec).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3058   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          90       90           
  Lines        4968     4968           
  Branches      624      624           
=======================================
  Hits         4942     4942           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member

Another point is that you need to create an account at Eclipse and then signe the Condibutor Agreement

https://www.eclipse.org/legal/eca/

@karianna
Copy link
Contributor

karianna commented Sep 8, 2024

Another point is that you need to create an account at Eclipse and then signe the Condibutor Agreement

https://www.eclipse.org/legal/eca/

This is now OK, but the translation isn't taking effect, other translation seems fine so maybe there's a missing hook for this page to say it's now translatable?

@karianna
Copy link
Contributor

Hmm, how to fire netlify again.

@xavierfacq
Copy link
Member

@gdams Can you provide information about this PR ? Does the new page need to be computed ? Thx

@xavierfacq
Copy link
Member

@gdams Can you provide information about this PR ? Does the new page need to be computed ? Thx

@gdams Can you help us on this point?

@xavierfacq xavierfacq requested a review from gdams October 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants