-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added German translation for the page "Temurin™ Download Buttons" #3058
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi, Thank you for your commit! I can't see your translation when I go to this preview page: https://deploy-preview-3058--eclipsefdn-adoptium.netlify.app/de/temurin/buttons/ I wonder if it's normal 🤔 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3058 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 90 90
Lines 4968 4968
Branches 624 624
=======================================
Hits 4942 4942
Misses 26 26 ☔ View full report in Codecov by Sentry. |
Another point is that you need to create an account at Eclipse and then signe the Condibutor Agreement |
This is now OK, but the translation isn't taking effect, other translation seems fine so maybe there's a missing hook for this page to say it's now translatable? |
Hmm, how to fire netlify again. |
@gdams Can you provide information about this PR ? Does the new page need to be computed ? Thx |
Description of change
I have added German translation for the page "Temurin™ Download Buttons".
German is my mother tongue.
Checklist