Fix osx native build #374
Merged
Fix osx native build #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Rushton <srushton@redhat.com>
smlambert
approved these changes
Nov 10, 2020
Mesbah-Alam
reviewed
Nov 10, 2020
| IFLAGS=-I. -I$(HEADERDIR) -I$(JAVA_HOME)/include/$(shell uname | tr "[:upper:]" "[:lower:]") -I$(JAVA_HOME)/include -I/usr/include | ||
| CFLAGS=-D_JNI_IMPLEMENTATION_ -D_TRIVIAL_AGENT -O0 -g3 -pedantic -c -Wall -std=c99 -fPIC -fno-omit-frame-pointer -m64 -o $(OBJDIR)/$(SRC)$(OSUFFIX) | ||
| LFLAGS=-shared -m64 -o | ||
| CC=cc |
There was a problem hiding this comment.
Do we need these indentation changes? The only real change in this PR seems to be the addition of -dynamiclib in LFLAGS. If we don't need the rest of the indentation changes, we probably should remove them from this PR for sake of consistency.
There was a problem hiding this comment.
Those "indentation changes" are replacing tabs which should only be used at the start of target commands with spaces - they should not have been there in the first place.
There was a problem hiding this comment.
I see. Just making sure it's a valid change.
|
Looks good to me. We should merge this PR and adoptium/aqa-tests#2048 after this week's releases are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Rushton srushton@redhat.com