Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to regenerate the bisheng non-smoke tests #2609

Closed
adamfarley opened this issue Jun 1, 2021 · 2 comments
Closed

Request to regenerate the bisheng non-smoke tests #2609

adamfarley opened this issue Jun 1, 2021 · 2 comments

Comments

@adamfarley
Copy link
Contributor

Summary:

Please regenerate all of the bisheng non-smoke tests in order to include a fix that allows them to run.

Note: We must verify that the resultant jobs have the default JDK_IMPL value set to "hotspot", even though the JDK_IMPL value in TEST_JOB_AUTO_GEN is set to "bisheng" (which I believe to be necessary so we regenerate the right jobs).

Test Sets:

LEVELS: sanity,extended
GROUPS: openjdk,perf,system
JDK_VERSIONS: 8,11
JDK_IMPL: bisheng
ARCH_OS_LIST: aarch64_linux,x86-64_linux

and

LEVELS: sanity,extended,special
GROUPS: functional
JDK_VERSIONS: 8,11
JDK_IMPL: bisheng
ARCH_OS_LIST: aarch64_linux,x86-64_linux

Details:

In this issue, we discussed how setting the JDK_IMPL value to "bisheng" causes the smoke tests to fail before they can run, and how this value should instead be "hotspot".

This change was effected by creating a PR that sets the JDK_IMPL value correctly during test job generation, followed by a deletion and re-creation of the aforementioned smoke tests.

However, this was all done without considering the non-smoke tests, which are now failing.

@smlambert - Asking for your thoughts on this, please.

@smlambert
Copy link
Contributor

Jobs listed above regenerated via:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Test_Job_Auto_Gen/264/
https://ci.adoptopenjdk.net/view/Test_grinder/job/Test_Job_Auto_Gen/265/ - openjdk regenerated separately to keep report dir equals true as default (when tests pass), unlike other test groups
https://ci.adoptopenjdk.net/view/Test_grinder/job/Test_Job_Auto_Gen/266/

@adamfarley
Copy link
Contributor Author

Thanks Shelley. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants