Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to regenerate the Bisheng smoke tests #2597

Closed
adamfarley opened this issue May 27, 2021 · 4 comments
Closed

Request to regenerate the Bisheng smoke tests #2597

adamfarley opened this issue May 27, 2021 · 4 comments
Milestone

Comments

@adamfarley
Copy link
Contributor

adamfarley commented May 27, 2021

The Bisheng smoke tests need to be regenerated to include a fix that enables them to work by changing a default parameter value (JDK_IMPL from bisheng to hotspot).

However, I'm not seeing an obvious way to do it via Test_Job_Auto_Gen.

Here are the four jobs that need to be regenerated. Help/Advice requested.

Plan B: If it's not currently possible to regenerate the smoke tests, I propose manually modifying the smoke tests listed above. Smoke tests created in the future should have the correct JDK_IMPL value as per the aforementioned PR.

@smlambert
Copy link
Contributor

Delete the smoke test jobs and on the next run they will get regenerated.

@adamfarley
Copy link
Contributor Author

Good idea Shelley. :)

I don't have the permissions to do this, unfortunately, so I'll ask if one of the Jenkins admins is around on the infra slack channel.

@smlambert
Copy link
Contributor

smlambert commented May 27, 2021

I've deleted the 4 jobs, so they will be regenerated next time build pipelines run. (Note: we specifically choose not to regen each time jobs are run, as its somewhat expensive and most often unecessary to do so.)

@karianna karianna added this to the May 2021 milestone May 27, 2021
@adamfarley
Copy link
Contributor Author

Thanks Shelley. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants