Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new security tests (Part 2: ssl-tests) #4403

Closed
smlambert opened this issue Mar 8, 2023 · 5 comments
Closed

Add new security tests (Part 2: ssl-tests) #4403

smlambert opened this issue Mar 8, 2023 · 5 comments
Assignees

Comments

@smlambert
Copy link
Contributor

smlambert commented Mar 8, 2023

Related to #3829 - this issue encapsulates the desire to add this set of tests:
https://github.com/rh-openjdk/ssl-tests to AQAvit.

To resolve this issue, we can follow the same approach as was done in Part 1: CryptoTests resolved by this #4327 (which resolved #4356).

@zzambers
Copy link
Contributor

zzambers commented Mar 10, 2023

ssl-tests should now be ready for inclusion. Jtreg scripts are located in jtreg-wrappers directory in project repo. In GH actions Temurins (8,11,17,19) are passing on linux/win/macos and also linux+jtreg.

Dependencies:

  • all variants need make and openssl tools
  • ssl-tests-gnutls-client.sh (linux only) additionally needs gnutls-bin package (ubuntu)
  • ssl-tests-nss-client.sh (linux only) additionally needs libnss3 libnss3-tools libnss3-dev gcc pkg-config packages (ubuntu; these are needed because ubuntu does not ship listsuites nss tool, so it needs to be built on the fly)

How to run as jtreg:
See github workflow.

@zzambers
Copy link
Contributor

I have done some experiments:

I have first tried to add this as functional same way as CryptoTest:
zzambers@57ec63c
but that failed due to missing openssl tool:
https://ci.adoptium.net/view/Test_grinder/job/Grinder/6990/

I have not seen a way to add system dependencies in functional tests, so I have tried external, where I saw docker is used and dependencies can be installed:
zzambers@e18746c
that one was eventually successful:
https://ci.adoptium.net/view/Test_grinder/job/Grinder/7007/

@zzambers
Copy link
Contributor

zzambers commented May 10, 2023

@smlambert I have just tested functional variant with one more fix [1], locally, on system where it has all system dependencies installed and it passed. I think you have said in some meeting, that this variant would need dependencies added to playbook somewhere. Is that something to be added somewhere in this repo, or is that different repo? Maybe here? [2]

[1] https://github.com/zzambers/aqa-tests/tree/ssl-tests-wip
[2] https://github.com/adoptium/infrastructure/tree/master/ansible

@smlambert
Copy link
Contributor Author

@zzambers - indeed for machine configuration (which we do via Ansible playbooks), we'd make the change in the playbooks in the infrastructure repo, https://github.com/adoptium/infrastructure. For guidance there, perhaps connect with @steelhead31 or @Haroon-Khel this week

@sophia-guo
Copy link
Contributor

In favour of #4835, close it.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Adoptium 4Q 2023 Plan Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants