-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssl-tests #4835
Add ssl-tests #4835
Conversation
FYI @pshipton @jasonkatonica |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zzambers - will await a machine to be ready so we can run some grinders before merging.
</then> | ||
<else> | ||
<if> | ||
<matches pattern="^[1][89]" string="${JDK_VERSION}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK18 and 19 are out of support. This if block should be removed.
<property name="jtregTar" value="jtreg_6_1_1"/> | ||
</then> | ||
<else> | ||
<property name="jtregTar" value="jtreg_7_1_1_1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jtreg_7_3_1_1 should be used for JDK21+.
Please check https://github.com/adoptium/aqa-tests/blob/master/openjdk/build.xml#L44-L67 for jtreg version.
I agree that we should put jtreg jar logic in a commonplace. I think we should get the SSL tests PR in first, then create a separate issue for moving jtreg jar logic in a commonplace. |
Created #4848 for addressing after this is delivered. |
As getting all native clients on all systems seems to complicated. I have came up with idea, how to check for presence of native clients by jtreg harness. This can than be used to skip cases, for which dependencies are not met (without showing "fake" passes): This way I could hopefully enable it everywhere and adapt testing based on what is available. |
After detection of native clients and some excludes on Mac in ssl-tests, 8: 21: 17: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @zzambers !
FYI @llxia - based on @zzambers changes (see #4835 (comment)), these can be run without worrying whether dependencies have been installed, so I will merge (and then setup a weekly run of dev.functional). |
Adds runner for ssl-tests suite. (Code is based on CryptoTest runner with some changes and later fixes included.)
This should wait until code adding dependencies is deployed on adoptium infra, see my comment in issue for dependencies.