Triage/Excluding tests #1348
Merged
Triage/Excluding tests #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2019 15:09
- Added issue for VMSupportsCS8 and un-excluded on 13 - Added issue to TimSortStackSize2 - Added issue to SpliteratorCollisions - Excluded CondyDescTest on 13
smlambert
reviewed
Sep 19, 2019
| java/util/concurrent/ArrayBlockingQueue/WhiteBox.java https://github.com/eclipse/openj9/issues/5988 macosx-all | ||
| java/util/logging/LogManager/TestLoggerNames.java https://github.com/eclipse/openj9/issues/4561 generic-all | ||
| java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
| java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1352 generic-all |
There was a problem hiding this comment.
You can add this 1352 link to the ones marked in #1297, close 1352 and use the 1297 link for tests that are permanent excludes due to them being hotspot specific.
There was a problem hiding this comment.
Yes, I was waiting for clarification if these tests were hotspot specific or not before adding them to the permanent exclude list. So are these tests both to be perma excluded?
There was a problem hiding this comment.
When i say these i mean this test on all 3 lists and also #1347
| java/util/concurrent/locks/Lock/TimedAcquireLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
| java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
| java/util/concurrent/locks/Lock/TimedAcquireLeak.java https://github.com/eclipse/openj9/issues/7125 macosx-all,linux-all | ||
| java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1352 generic-all |
There was a problem hiding this comment.
same comment as above, let's amalgamate all non-applicable permanent excludes under 1297
| java/util/concurrent/locks/Lock/TimedAcquireLeak.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
| java/util/concurrent/ThreadLocalRandom/ThreadLocalRandomTest.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 linux-all | ||
| java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/821 windows-all | ||
| java/util/logging/CheckZombieLockTest.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 generic-all | ||
| java/util/logging/FileHandlerMaxLocksTest.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
| java/util/logging/TestLoggerWeakRefLeak.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
| java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1352 generic-all |
|
I will review one more time and merge once you resolve the conflicts please. :) |
|
Done :) |
smlambert
approved these changes
Sep 24, 2019
pshipton
added a commit
to pshipton/openjdk-tests
that referenced
this pull request
Dec 20, 2022
It was unexcluded via adoptium#1350 but seems to have been accidently re-excluded via adoptium#1348 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openjdk-tests
that referenced
this pull request
Dec 20, 2022
It was unexcluded via adoptium#1350 but seems to have been accidentally re-excluded via adoptium#1348 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
smlambert
pushed a commit
that referenced
this pull request
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Thorpe adam.thorpe@ibm.com