Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user guide for exclude feature #2055

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Add user guide for exclude feature #2055

merged 1 commit into from
Nov 14, 2020

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Nov 13, 2020

Signed-off-by: renfeiw renfeiw@ca.ibm.com

@renfeiw renfeiw requested review from smlambert and llxia November 13, 2020 15:06
@renfeiw
Copy link
Contributor Author

renfeiw commented Nov 13, 2020

related PR: #2053

@karianna karianna added the bug label Nov 13, 2020
@karianna karianna added this to the November 2020 milestone Nov 13, 2020
@renfeiw renfeiw added docs and removed bug labels Nov 13, 2020
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor additions suggested, otherwise looks good, thanks @renfeiw !

doc/userGuide.md Outdated
@@ -309,3 +309,72 @@ openjdk-tests/test-results/openjdk/report
```

The JTREG report HTML summary file is then located at `openjdk-tests/test-results/openjdk/report/html/index.html`

## Disable test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change heading to
Disable a test target

doc/userGuide.md Outdated
## Disable test

#### Automatically exclude a test target
In the issue that describes the test failure, add a comment with the following format:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to
Instead of having to manually create a PR to disable test targets, they can now be automatically disabled via Github workflow (see autoTestPR.yml). In the issue that describes the test failure, add a comment with the following format:

doc/userGuide.md Outdated

```auto exclude test jdk_test_1```

After the comment is left, there will be a auto PR created with the exclude change in the playlist.xml. The PR will be linked to issue. If the testName can not be found in the repo, no PR will be created and there will be a comment left in the issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... a comment left in the issue linking to the failed workflow run for more details.

@renfeiw renfeiw force-pushed the doc branch 3 times, most recently from c2160ad to 57231c2 Compare November 13, 2020 16:18
Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@karianna karianna merged commit 049abcf into adoptium:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants