Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add vendor-specific tests for jdk builds #2140

Conversation

adamfarley
Copy link
Contributor

These tests ensure that any vendor-specific build changes or fixes
are present and functional in the created builds on relevant
platforms, versions, etc.

The freetype and cuda tests are included in this change, as
documented.

Signed-off-by: Adam Farley adfarley@redhat.com

These tests ensure that any vendor-specific build changes or fixes
are present and functional in the created builds on relevant
platforms, versions, etc.

The freetype and cuda tests are included in this change, as
documented.

Signed-off-by: Adam Farley <adfarley@redhat.com>
@adamfarley adamfarley changed the title Add vendor-specific tests for jdk builds WIP: Add vendor-specific tests for jdk builds Jan 4, 2021
@adamfarley adamfarley self-assigned this Jan 4, 2021
@adamfarley
Copy link
Contributor Author

Running various tests now and resolving issues as they spring up. Will tag people for reviews and feedback (including Shelley) once the tests are passing.

@adamfarley
Copy link
Contributor Author

adamfarley commented Jan 4, 2021

Tests still running. Thought of a few improvements as well, and they're in there too. Still a couple of issues left, including not knowing how to check for cuda enablement on Windows. For some reason the "cudart" string isn't present in the j9prt file even if cuda functionality is definitely enabled during the config stage of the build.

Will double-check I'm testing the right Windows build, and raise it with the OpenJ9 folks.

EDIT: Checked another build and cudart is present. My mistake, or an intermittent issue? These tests will alert us to the issue in the future, so it's a good thing we'll have them now.

@karianna karianna added this to the January 2021 milestone Jan 5, 2021
@aahlenst
Copy link
Contributor

aahlenst commented Jan 6, 2021

Are you aware of #2067? Or is this PR already the right way to solve the problems discovered in aforementioned PR?

Regardless, I find it useful if those tests are comprehensive. This means we should not only test for the presence of CUDA on Windows but also for the absence everywhere else (as far as possible). This would allow us to detect changes.

@smlambert
Copy link
Contributor

Will combine this PR, with #2067 and house in a test dir in the openjdk-build repo (to be run as an independent smoke test which must pass in order for the AQA test jobs to be triggered). We will leave this open form until the new combined openjdk-build PR lands.

@adamfarley
Copy link
Contributor Author

Closing this, as the parts which are going to be used are being merged into this PR.

Will leave the branch hanging around for a while, in case it's needed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants