Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture openjdk repo and sha in testenv.properties #3196

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Capture openjdk repo and sha in testenv.properties #3196

merged 1 commit into from
Jan 10, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jan 5, 2022 •
edited
Loading

Related: #2916 #2347
Depends: adoptium/TKG#256

Signed-off-by: lanxia lan_xia@ca.ibm.com

@llxia
Capture openjdk repo and sha in testenv.properties
2f23780 
Related: adoptium#2916
Depends: adoptium/TKG#256

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Jan 5, 2022 •
edited
Loading

# USE_TESTENV_PROPERTIES JDK_IMPL Grinder testenv.properties
1 false openj9 https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2941 JDK11_OPENJ9_REPO=https://github.com/ibmruntimes/openj9-openjdk-jdk11.git
JDK11_OPENJ9_BRANCH=d1525ba73a57b2ca44dca7936cc6bc94693269e4
2 false hotspot https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2942 JDK11_REPO=https://github.com/adoptium/jdk11u.git
JDK11_BRANCH=d94b2aec24e7dba72e526e49b9d327708e0c5dad
3 true (consume testenv.properties from 1) openj9 https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2945

@llxia llxia marked this pull request as ready for review January 6, 2022 16:33
@llxia llxia requested review from smlambert and renfeiw January 6, 2022 16:34
renfeiw
renfeiw approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smlambert
smlambert approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@renfeiw renfeiw merged commit 11c721b into adoptium:master Jan 10, 2022
@llxia llxia mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renfeiw renfeiw renfeiw approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llxia @smlambert @renfeiw