-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jck.mk and 'tests' value of compiler.lang/playlist.xml do not match #4590
Conversation
Thanks for your interest @yaqsun Running You are likely running it because you are running make _jck (which picks up and runs all test targets from all levels unless those targets are disabled. 2 ways to proceed here:
So, instead of any of the changes you are proposing in this PR, I am proposing that the To disable the targets, please add:
inside the Other things to note, the changes in jck.mk are generated by running the https://github.com/adoptium/aqa-tests/blob/master/jck/splitter/splitter.sh script, so we do not hand edit those entries. If there is an issue with them, we'd look to update splitter.sh. |
@yaqsun You'll also need to sign the Eclipse Contributor Agreement |
Thank you for your reply and also for your introduction of the two handling methods. @smlambert |
thanks. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per #4590 (comment), please update this PR by disabling the targets, instead of the approach currently taken. Or close this and create a new PR with that approach. Thanks!
…LMBD-group7_multijvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
running jck-compiler-lang-LMBD-group6_multijvm, jck-compiler-lang-LMBD-group7_multijvm and jck-compiler-lang-ANNOT-group5_multijvm results in the following error, so jck.mk and 'tests' value of compiler.lang/playlist.xml were modified.