Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit rmi services to only rmi test + Add agent startup to jdwp + fix false negative #4607

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Jun 5, 2023

  • Limit rmi services startup to only rmi test.
  • Add agent startup to jdwp.
  • Remove -ue from agent-drive.sh to not exit script when harness fails (allows agent-drive.sh to stop all services started-- fixing the hang issue on java_net and java_util).
  • Capture and return exit value of harness from agent-drive.sh. Additionally, in the playlists, move $(TEST_STATUS); immediately below the javatest command, ahead of result summary generation. This ensures TKG can mark the test as 'failed' when it fails-- fixing the false negative issue.

@Mesbah-Alam Mesbah-Alam force-pushed the investigate-jdwp branch 3 times, most recently from 1c56141 to d1c776b Compare June 5, 2023 17:14
@Mesbah-Alam Mesbah-Alam force-pushed the investigate-jdwp branch 13 times, most recently from bb73622 to 3790c7d Compare June 5, 2023 23:04
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for my use case, so I'm approving on the basis it makes it significantly less broken than it is at the moment ;-)

@Mesbah-Alam Mesbah-Alam force-pushed the investigate-jdwp branch 2 times, most recently from 5ed2e39 to 6e83752 Compare June 6, 2023 15:41
@Mesbah-Alam Mesbah-Alam changed the title Limit rmi services to only rmi test + Add agent startup to jdwp Limit rmi services to only rmi test + Add agent startup to jdwp + fix false negative Jun 6, 2023
@Mesbah-Alam Mesbah-Alam force-pushed the investigate-jdwp branch 6 times, most recently from b1b17fb to 5271ccc Compare June 7, 2023 15:02
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jun 8, 2023

Test :

  • sanity.jck with jdk 8 (x64 Linux) : Grinder_JCK/1435 (Green)
  • extended.jck with jdk11 (s390x) : Grinder_JCK/1436 (Amber - with some real test failures)
  • Jdwp with temirun 17 (aarch64 Linux): Grinder_JCK/1392 (green)

@Mesbah-Alam Mesbah-Alam requested review from llxia and smlambert June 8, 2023 15:45
@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review June 8, 2023 15:45
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Mesbah-Alam !

@smlambert smlambert merged commit 8a34f55 into adoptium:master Jun 8, 2023
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jun 12, 2023

FYI, this PR introduces a new constraint: While running TCK target(s) in Grinder, always set KEEP_REPORTDIR=true. This is already the default setting in the automated jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants