Improve core count detection #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit in this PR fixes the core count detection for CGROUPS (It was using GB instead of MB) so now has the desired effect. This is now ready for review. These commits are going to need a good squashing ... |
7 tasks
|
Right I believe it's working well in all cases now, these runs are all with the new branch:
NOTE: The TC-aix72 figures probably shouldn't be I've squashed the commits so this should be ready to go live as soon as is practical. |
Signed-off-by: Stewart X Addison <sxa@redhat.com>
luhenry
approved these changes
Dec 22, 2023
sophia-guo
approved these changes
Dec 22, 2023
smlambert
approved these changes
Dec 22, 2023
sophia-guo
pushed a commit
to sophia-guo/openjdk-tests
that referenced
this pull request
Jan 11, 2024
Signed-off-by: Stewart X Addison <sxa@redhat.com>
smlambert
added a commit
that referenced
this pull request
Jan 11, 2024
* Use all cores for jtreg instead of halving (#4933) Signed-off-by: Stewart X Addison <sxa@redhat.com> * Enable headless mode on RISC-V (#4935) * Exclude java/lang/StringBuilder/HugeCapacity.java on OpenJ9 zlinux (#4940) It's already excluded on jdk17+ for other reasons. Issue eclipse-openj9/openj9#17323 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Move custom targets to special level (#4941) Signed-off-by: Shelley Lambert <slambert@gmail.com> * Add 21 and 22 as supported versions in external tests (#4950) related: #4949 Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com> * cherry-pick e37ba10 c5e7de8 0d7c837 76695ca 37b48e3 a45c03c Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> --------- Signed-off-by: Stewart X Addison <sxa@redhat.com> Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Signed-off-by: Shelley Lambert <slambert@gmail.com> Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com> Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com> Co-authored-by: Ludovic Henry <git@ludovic.dev> Co-authored-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Co-authored-by: Shelley Lambert <slambert@gmail.com> Co-authored-by: Lan Xia <Lan_Xia@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I drafted and tested this a few months for the RISC-V case (everything was getting
concurrency:1) but since we're paying more attention to the AQA test jobs for RISC-V now I want to get this in so we can make use of the multicore machines that we have.Ref: adoptium/temurin-build#3591
[*] - This value of 81 suggests that the detection in a docker container is not working as it should and will need to be revised before this is merged, hence the draft status at present.