Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add howto contribution iteration 1 #5471

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

andrlos
Copy link
Contributor

@andrlos andrlos commented Jul 31, 2024

Hi!
#1558
@smlambert told me, that this is where I am supposed to contribute some documentation to the aqa-tests.. this is something I promised a long time ago. Do I think it is perfect? Hell no.. we can discuss on what to add how to improve it here tho :-)
Cheers!

docs/pages/aqa-howto.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
andrlos and others added 2 commits August 2, 2024 08:36
Co-authored-by: Shelley Lambert <slambert@gmail.com>
additional review-based changes that were not commited in a batch commit
@andrlos
Copy link
Contributor Author

andrlos commented Aug 2, 2024

review suggestions implemented, however the alignment on step 4. is still off

step 4 indentation fixed
@karianna karianna requested a review from smlambert August 3, 2024 08:36
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor change request, otherwise LGTM. Thanks @andrlos !

docs/pages/howto/first-contrib.markdown Outdated Show resolved Hide resolved
Co-authored-by: Shelley Lambert <slambert@gmail.com>
@andrlos andrlos mentioned this pull request Aug 5, 2024
@karianna karianna merged commit fa9e609 into adoptium:master Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants