Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the OpenJcePlusTests to FIPS140_3_OpenJCEPlusFIPS and FIPS140_3_OpenJCEPlusFIPS.FIPS140-3 #5606

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Updated the OpenJcePlusTests to FIPS140_3_OpenJCEPlusFIPS and FIPS140_3_OpenJCEPlusFIPS.FIPS140-3 #5606

merged 1 commit into from
Sep 17, 2024

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Sep 13, 2024

Signed-off-by: Anna Babu Palathingal anna.bp@ibm.com

related:#5605

llxia
llxia reviewed Sep 13, 2024
View reviewed changes
functional/OpenJcePlusTests/build.xml Outdated
Comment on lines 126 to 127
<contains string="${TEST_FLAG}" substring="FIPS140_3_OpenJCEPlusFIPS"/>
<contains string="${TEST_FLAG}" substring="FIPS140_3_OpenJCEPlusFIPS.FIPS140-3"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<contains string="${TEST_FLAG}" substring="FIPS140_3_OpenJCEPlusFIPS"/> is sufficent. We do not need the second line

@annaibm
Updated the OpenJcePlusTests to FIPS140_3_OpenJCEPlusFIPS or FIPS140_…
140f0b2 
…3_OpenJCEPlusFIPS

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>

related:adoptium#5605
@annaibm annaibm force-pushed the updateTESTFLAGOPenJCE branch from c72cbc5 to 140f0b2 Compare September 13, 2024 20:35
@llxia
Copy link
Contributor

llxia commented Sep 16, 2024

Please provide Grinder links.

@annaibm
Copy link
Contributor Author

annaibm commented Sep 16, 2024

Grinder links:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43177/
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43178/

@llxia
Copy link
Contributor

llxia commented Sep 16, 2024

The test is skipped in both Grinder.

@llxia
Copy link
Contributor

llxia commented Sep 16, 2024

For OpenJcePlusTests, you need to use Semeru build.

@annaibm
Copy link
Contributor Author

annaibm commented Sep 17, 2024

Grinder links with Semeru builds
s390x_linux
TEST_FLAG:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43224/

TEST_FLAG:FIPS140_3_OpenJCEPlusFIPS
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43227/

ppc64le_linux
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43225/testReport/

FIPS140_3_OpenJCEPlusFIPS
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43228/

@llxia
Copy link
Contributor

llxia commented Sep 17, 2024

  • The PR title has a typo. The two flags are FIPS140_3_OpenJCEPlusFIPS and FIPS140_3_OpenJCEPlusFIPS.FIPS140-3
  • Please run a Grinder with FIPS140_3_OpenJCEPlusFIPS.FIPS140-3 as well

@annaibm annaibm changed the title Updated the OpenJcePlusTests to FIPS140_3_OpenJCEPlusFIPS or FIPS140_3_OpenJCEPlusFIPS Updated the OpenJcePlusTests to FIPS140_3_OpenJCEPlusFIPS and FIPS140_3_OpenJCEPlusFIPS.FIPS140-3 Sep 17, 2024
@annaibm
Copy link
Contributor Author

annaibm commented Sep 17, 2024

Grinder link:
FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:-
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43235/

llxia
llxia approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from LongyuZhang September 17, 2024 21:05
@annaibm annaibm marked this pull request as ready for review September 17, 2024 21:06
@LongyuZhang LongyuZhang merged commit 079918e into adoptium:master Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annaibm @llxia @LongyuZhang