Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: promote hotspot test to extended level #5624

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

zzambers
Copy link
Contributor

Promote hotspot_gc, hotspot_runtime, hotspot_serviceability to extended level. See: #5424

Results of dev.openjdk (jdk21, jdk11) show just 1 serviceability issue. I have done other PR to exclude it.

@karianna karianna requested a review from smlambert September 19, 2024 05:07
@sophia-guo
Copy link
Contributor

dev.openjdk is only enabled for linux_x64, which need extra label 'sw.tool.docker' to ensure tests running on the agent with docker installed. @zzambers are those tests working for all platforms and no docker needed?

@sophia-guo
Copy link
Contributor

@zzambers
Copy link
Contributor Author

dev.openjdk is only enabled for linux_x64, which need extra label 'sw.tool.docker' to ensure tests running on the agent with docker installed. @zzambers are those tests working for all platforms and no docker needed?

Docker should not be necessary. I am keeping hotspot_container and hotspot_container_jdk8 in dev.

@zzambers
Copy link
Contributor Author

When it comes to other platforms, I would not expect (many) problems there, as I have done quite a lot of testing on different platforms as part of introducing them in current form: #5367

@zzambers
Copy link
Contributor Author

zzambers commented Sep 25, 2024

I have realized I have not done MacOS testing in PR I referenced above.
So I have done them now:

jdk21 / x86-64_mac
hotspot_gc: OK
hotspot_runtime: 5 FAILURES

runtime/cds/CheckDefaultArchiveFile.java.CheckDefaultArchiveFile
runtime/cds/TestCDSVMCrash.java.TestCDSVMCrash
runtime/cds/appcds/CommandLineFlagCombo.java.CommandLineFlagCombo
runtime/cds/appcds/TestDumpClassListSource.java.TestDumpClassListSource
runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveNoDefaultArchive.java.TestAutoCreateSharedArchiveNoDefaultArchive

hotspot_serviceability: 1 FAILURE

serviceability/jvmti/RedefineClasses/RedefineSharedClassJFR.java.RedefineSharedClassJFR

There are some failures, but all of them seem to be caused by missing jsa archive on macOS. I'll create issue and exclude them.

@zzambers
Copy link
Contributor Author

Failing tests MacOS excluded: #5647

@sophia-guo sophia-guo merged commit 60f23a3 into adoptium:master Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants