Finish/fix SKIP_JCK_GIT_UPDATE variable in JCK #5740
Conversation
|
Well if it is not used in AzDo, I would like to use it. Because I have tck test-jars stored in binary, and distributed without repository. So I can prepare JCK_ROOT directly, and stop transforming it to repository which is quite expensive operation. |
jck/build.xml
Outdated
| <not> | ||
| <equals arg1="${return.code}" arg2="0"/> | ||
| </not> | ||
| <isset property="env.SKIP_JCK_GIT_UPDATE" /> |
There was a problem hiding this comment.
Since SKIP_JCK_GIT_UPDATE is a boolean, the check will always return true as long as it is set. Maybe check to assess the specific value of env.SKIP_JCK_GIT_UPDATE instead of checking if it's set.
<equal arg1="{env.SKIP_JCK_GIT_UPDATE}" arg2="true">
There was a problem hiding this comment.
The original code was just checking the "is set" . I have absolutely no objections to change it to explicit value. TY!
|
I opened an issue in temurin-compliance. More discussion will be moved there |
|
ty! Will follow |
|
@karianna Sophia (@sophia-guo )is in favour to change the |
|
We will assume that the AzDo use case is very similar to RH QE use case where 1) they are not using our Jenkinsfile code and 2) the TCK materials are housed somewhere of their choosing and they will manage the update of them outside of this framework. Tagging @d3r3kk for awareness |
judovana
force-pushed
the
skippableJckGitRepo
branch
from
ac9fe9a to
aae8145
Compare
judovana
force-pushed
the
skippableJckGitRepo
branch
from
aae8145 to
d1a9c6f
Compare
|
Tahnx all, changed to check for explicit "true". |
|
Temurin-compliance grinder/2632,4634,4635 work as expected. |
|
tyvm! |
* Do not enforce JCK_GIT_REPO if SKIP_JCK_GIT_UPDATE is set * Skipping all git checks when SKIP_JCK_GIT_UPDATE is set * Adding SKIP_JCK_GIT_UPDATE to readme * Updated usage of SKIP_JCK_GIT_UPDATE so it needs to be true, not just set
It seems the SKIP_JCK_GIT_UPDATE was not finished/was single usage targeted/or was broken in later commits.
Before this PR, the JCK_GIT_REPO was mandatory to exists even if the SKIP_JCK_GIT_UPDATE was on place. In addition, the JCK_ROOT (which was supposed to be not updated) was deleted if the checks failed.
This PR is extending the usage of SKIP_JCK_GIT_UPDATE so the JCK_GIT_REPO is nto used at all and JCK_ROOT do not need to pass the git checs ( so it do not need to be repo art all)
Small side note - to fake git repo, which contains unpacked compatibility jars, takes some 30 minutes and used pretty quite a lot of disk space. This PR is making this creation of fake repository redundant.
#5745