Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problemlist Test RmiRegistrySslTest.sh and RmiSslBootstrapTest.sh in jdk8u #5744

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

sendaoYan
Copy link
Contributor

Problemlist jtreg tests RmiRegistrySslTest.sh and RmiSslBootstrapTest.sh in jdk8u, before the upstream PR has been integrated.

Fixes: #5743

…jdk8u

Problemlist jtreg tests RmiRegistrySslTest.sh and RmiSslBootstrapTest.sh in jdk8u, before the upstream PR has been integrated.

Fixes: adoptium#5743
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@sophia-guo
Copy link
Contributor

The issue is tagged as jdk8u-fix-request would fix be ready in a short time? If it's urgent probably excluded by alibaba vendor?

@sendaoYan
Copy link
Contributor Author

The issue is tagged as jdk8u-fix-request would fix be ready in a short time? If it's urgent probably excluded by alibaba vendor?

Most of the PR seems have long period to integrated to jdk8u-dev. But I think excluded only by alibaba vendor also acceptable. The two Problemlist entries has been move to vendor/alibaba/Problemlist.txt

@smlambert
Copy link
Contributor

@sophia-guo @sendaoYan - this is a test failure that affects everyone, so it should be in the shared ProblemList file, not in the vendor ProblemList file.

@sophia-guo
Copy link
Contributor

The issue is tagged as jdk8u-fix-request would fix be ready in a short time? If it's urgent probably excluded by alibaba vendor?

If it takes long time for the fix, yes, it should be excluded in the shared ProblemList. Considered it's not a fatal failure and next release is January 2025 might not bother to do the exclude. As it's fatal alert for alibaba dragonwell-project/dragonwell8#694 I think exclude to Alibaba should be good.

@smlambert
Copy link
Contributor

smlambert commented Nov 12, 2024

The issue is not how fast an upstream fix would go in, since it is very easy / very little overhead to add/remove an exclusion in our repo. The point is whether it affects most vendors or only one. In this case, since it is an upstream issue, affecting most vendors, it belongs in the common problem list.

@sendaoYan
Copy link
Contributor Author

sendaoYan commented Nov 13, 2024

The Problemlist entries for RmiRegistrySslTest.sh and RmiSslBootstrapTest.sh has been moved to common exclude file for jdk8u.
And I also commet or remove the duplicated Problemlist entyies in openjdk/excludes/ProblemList_openjdk8-openj9.txt. I'am not sure does this change suitebale or not. If the remove action in openjdk/excludes/ProblemList_openjdk8-openj9.txt doesn't needed, please let me konwn.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to change the ProblemList_openjdk8-openj9.txt file.

@sendaoYan
Copy link
Contributor Author

The change to openjdk/excludes/ProblemList_openjdk8-openj9.txt has been backout.

@sophia-guo sophia-guo merged commit b647336 into adoptium:master Nov 13, 2024
3 checks passed
@sendaoYan sendaoYan deleted the issue5743 branch November 14, 2024 01:06
@sendaoYan
Copy link
Contributor Author

Thanks all for the review and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problemlist Test RmiRegistrySslTest.sh and RmiSslBootstrapTest.sh
3 participants