Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOB6: Security Fix ; Include Checksum Validation Of Dragonwell JDK Download. #1000

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #999

Include an integrity check for the Dragonwell JDK8 download. the aarch64 dockerfile does this, so the fix is only required for x64.

Ref: TOB-TEMURIN-6

Copy link

github-actions bot commented Apr 9, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added aarch x64 Issues that affect or relate to the x64/x32 LINUX OS labels Apr 9, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - that's one I was going to try and get to today :-)

@steelhead31 steelhead31 merged commit f11492f into adoptium:master Apr 9, 2024
6 checks passed
@steelhead31 steelhead31 deleted the fix_tob_6 branch April 9, 2024 09:54
@steelhead31
Copy link
Contributor Author

Thanks - that's one I was going to try and get to today :-)

Hehe, Im picking up little things, as I finish testing the installer changes.

@sxa
Copy link
Member

sxa commented Apr 9, 2024

Woohoo - congrats on having issue/PR 1000 in this repo ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch docker jenkins-pipeline x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing integrity check in Dragonwell Dockerfile
3 participants