-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add riscv64 to JDK17 release pipeline #1024
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (once you've addressed Martijn's change)
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
* add riscv64 to JDK17 release pipeline Signed-off-by: Stewart X Addison <sxa@redhat.com> * Update pipelines/jobs/configurations/jdk17u_release.groovy Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> --------- Signed-off-by: Stewart X Addison <sxa@redhat.com> Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
* add riscv64 to JDK17 release pipeline Signed-off-by: Stewart X Addison <sxa@redhat.com> * Update pipelines/jobs/configurations/jdk17u_release.groovy Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> --------- Signed-off-by: Stewart X Addison <sxa@redhat.com> Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
This will be formally discussed at the next PMC meeting before performing a release, but this change will allow us to be able to release a JDK17 on Linux/riscv64 which is believed to be in a good state now, and this will allow us to fully prep and test a release prior to shipping.