Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pass node label to windows installer job #1025

Merged
merged 1 commit into from
May 3, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented May 3, 2024

Now that we define the installer job as a Jenkinsfile it makes more sense to define this there.

Also fixes JVM which we've been incorrectly passing in as temurin for some time now

Copy link

github-actions bot commented May 3, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added jenkins-pipeline installer Issues that relate to our installer jobs or installer repo windows labels May 3, 2024
@gdams gdams enabled auto-merge (squash) May 3, 2024 13:16
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams gdams merged commit c82d8ce into adoptium:master May 3, 2024
5 checks passed
@gdams gdams deleted the installers branch May 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer Issues that relate to our installer jobs or installer repo jenkins-pipeline windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants