Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple Windows exe/dll signing and verify #1157

Merged
merged 15 commits into from
Dec 11, 2024
Merged

Prevent multiple Windows exe/dll signing and verify #1157

merged 15 commits into from
Dec 11, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Dec 5, 2024 •
edited
Loading

Fixes adoptium/temurin-build#3997

  • Update verify_signing.groovy to check Windows exes only have one Eclipse signature and Microsoft DLLs are not signed by Eclipse
  • Update inline build Windows signing to skip Windows supplied DLLs

@andrew-m-leonard
Update verify_signing.groovy to check Windows exes only have one sign…
4b16a3e 
…ature

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard self-assigned this Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard andrew-m-leonard marked this pull request as draft December 5, 2024 12:08
@andrew-m-leonard
Update verify_signing.groovy to check Windows exes only have one sign…
fe5b0b9 
…ature

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Update verify_signing.groovy to check Windows exes only have one sign…
052adf5 
…ature

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Update verify_signing.groovy to check Windows exes only have one sign…
6dfeb14 
…ature

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
7c44470 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
ccc2ce7 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
7aeeedd 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
9a76577 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
2832f7e 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
d775739 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
79eb418 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
b42ffe1 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
03537b1 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review December 9, 2024 08:57
@andrew-m-leonard
Copy link
Contributor Author

run tests

@andrew-m-leonard andrew-m-leonard mentioned this pull request Dec 9, 2024
Merged
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@github-actions github-actions bot added testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS labels Dec 9, 2024
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
6d2ab9e 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Prevent jdk11+ from running external sign.sh as already signed during…
07a44dd 
… build

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Dec 11, 2024 •
edited
Loading

Test builds:

steelhead31
steelhead31 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrew-m-leonard andrew-m-leonard merged commit 98add17 into adoptium:master Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@karianna karianna karianna approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
jenkins-pipeline testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows builds have two Eclipse signatures in the executables
4 participants
@andrew-m-leonard @eclipse-temurin-bot @karianna @steelhead31