Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jdk21 pipeline config to jdk21u #820

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

Rename jdk21 pipeline job configuration to jdk21u.

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa
Copy link
Member

sxa commented Sep 26, 2023

Hmm do really want to do a rename when we haven't actually shipped jdk21GA so there's always the possibility of a reason (albeit small)?

Regardless, we should ensure that nothing gets schedules to run and publish from jdk21u automatically at the moment as the latest nightly/EA really needs to stay pointing at jdk-21+35 for now until we so the release build.

@sxa
Copy link
Member

sxa commented Sep 26, 2023

Also as a point of note; Please do not remove the JDK21 experimental build pipelines as I have some custom books in there that I don't want to lose.

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Sep 26, 2023

Hmm do really want to do a rename when we haven't actually shipped jdk21GA so there's always the possibility of a reason (albeit small)?

Regardless, we should ensure that nothing gets schedules to run and publish from jdk21u automatically at the moment as the latest nightly/EA really needs to stay pointing at jdk-21+35 for now until we so the release build.

@sxa
We have the v2023.09.01 branch with the release (jdk21) configuration:
https://github.com/adoptium/ci-jenkins-pipelines/tree/v2023.09.01/pipelines/jobs/configurations

We can pause this for the moment, i've disabled the releaseTrigger_21ea job to ensure that: https://ci.adoptium.net/job/build-scripts/job/utils/job/releaseTrigger_21ea/

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member

sxa commented Sep 26, 2023

We have the v2023.09.01 branch with the release (jdk21) configuration:

Yep my primary concern here was to make sure that we have new jdk21u things generated and retain the existing jdk21 ones (so that branch could still use the old jobs if needed) and that we didn't rename/delete the existing ones

@andrew-m-leonard
Copy link
Contributor Author

We have the v2023.09.01 branch with the release (jdk21) configuration:

Yep my primary concern here was to make sure that we have new jdk21u things generated and retain the existing jdk21 ones (so that branch could still use the old jobs if needed) and that we didn't rename/delete the existing ones

@sxa so we have the Jenkins release jobs and pipelines, all based off of the v2023.09.01 branch:
https://ci.adoptium.net/job/build-scripts/job/jobs/job/release/job/jobs/job/jdk21/
https://ci.adoptium.net/job/build-scripts/job/release-openjdk21-pipeline/

And they will not get re-generated unless someone does a manual release re-gen for jdk-21.0.1, and hopefully that point in time should be close to Oct 17th..

@karianna karianna merged commit 5f6ba49 into adoptium:master Sep 28, 2023
7 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants