-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMOD signing retry and check curl rc #823
Conversation
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wrap this in a flag or comment what we should revert later?
I think having an issue is probably best as this retry logic is in multiple places/repos, raised adoptium/temurin-build#3496 |
run tests |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
This reverts commit 16502bc.
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Add retry to the JMOD Windows&Mac signing, as a workaround until EF upstream issue is resolved: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3758
This is likely to fail during the release builds with the current failure rate.