-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all Mac & Windows jdk.jpackage jmod executables are correctly signed #831
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
Test build JDK looks good, JMOD jdk.jpackage resource exe/dll's are signed correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm not an expert in this area the fix seems to have the desired effect, so approving :-)
…signed Signed-off-by: Andrew Leonard <anleonar@redhat.com>
/merge |
faa1269
to
dc2b838
Compare
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
/approve |
1 similar comment
/approve |
Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.
…signed (adoptium#831) Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…signed (adoptium#831) Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Ensure all the jdk.package JMOD executable resources are Signed
I think the stashing created a 0 length jpackagelauncher file, which then got .exe added and resulting empty file.
This PR ensures the whole jdk.jpackage resources folder is stashed for passing to the EF signing service.